[EVM] adding commitment over state updates #6451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6451 +/- ##
==========================================
+ Coverage 41.44% 41.47% +0.03%
==========================================
Files 2026 2027 +1
Lines 144629 144711 +82
==========================================
+ Hits 59937 60019 +82
+ Misses 78492 78484 -8
- Partials 6200 6208 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
janezpodhostnik
approved these changes
Sep 10, 2024
…low-go into ramtin/evm-add-delta-commitment
sideninja
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the StateDB to return a commitment over the update when Commit is called. This data can be used later for validating re-execution of transactions off-chain. A follow-up PR can expose this value as part of events.
This pr and follow-up needs to be ported to the mainnet branch later.
This PR doesn't change any behaviour but is recommended to release it with follow-up PRs as an HCU (+ update to EVM contract update).